-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to specify custom annotations for the service helm template #190
base: main
Are you sure you want to change the base?
Conversation
371a122
to
b9bd895
Compare
#sre |
Thanks for this PR, sounds good to me. But Kubernetes service has not test yet, can I ask you to add the 2 following changes:
service:
annotations:
annotation1: value1
# yaml-language-server: $schema=https://raw.githubusercontent.com/helm-unittest/helm-unittest/main/schema/helm-testsuite.json
---
suite: grafana dashboard tests
templates:
- service.yaml
tests:
- it: render default service
asserts:
- isKind:
of: Service
- hasDocuments:
count: 1
- it: with custom service
values:
- ./values/with_service.yaml
asserts:
- equal:
path: metadata.annotations.annotation1
value: value1 With this configuration, we'll test in the CI that Kubernetes service return is valid according to the Kubernetes api. |
@vmercierfr wow, i haven't noticed the tests for helm chart. since it is MIT licensed repository it is definitely something i will be looking to "steal" into my OS repos 😄 |
cdf9cfd
to
c112544
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I can't say why it's failing with EOF error in your environment, but it's correct and I can run the test suite with success (using Helm 3.13 and 3.15).
In order to merge the PR, @kuskoman can you sign all your commits ( See Github Reference |
c112544
to
11bd0de
Compare
ahh, i signed 3rd part commits by mistake, lemme fix that |
ecdd1af
to
d934789
Compare
@vmercierfr since i started from your current head with just a single commit, could you rerun the tests just to make sure? now the branch should be in the correct state |
Tests are ok:
But git commits are not correctly signed; you should have a |
036033b
to
1ff6c72
Compare
Signed-off-by: Jakub Surdej <jakub.sudej@shift4.com> Signed-off-by: Jakub Surdej <kubasurdej@gmail.com>
Signed-off-by: Jakub Surdej <jakub.sudej@shift4.com> Signed-off-by: Jakub Surdej <kubasurdej@gmail.com>
1ff6c72
to
a97c640
Compare
No description provided.